feat: Add option to set fwmark on the socket#60
Conversation
5f07054 to
95fec7c
Compare
|
Hi, please avoid the unrelated format changes. If we should fix the format issue, we can do it in a separated PR. |
|
That's why I put them into separate commits, so you can cleanly review the feature commit. I can create a separate PR to get them merged first, but I doesn't make much difference. |
|
I will squash merge this PR because I want to re-write the commit history to apply the gitmoji commit conversion, multiple changes in the same PR will block this. And it makes the review a little bit more harder, also I know how to just check the diff in one commit, but other people may have trouble with it. |
|
I tried to use this change now, but it doesn't work. The ping stops working as soon as the fwmark is set. I first thought that it might only work on raw sockets (that's how I use it already), but switching to that didn't help. I'll mark this PR as ready, as soon as I've found a solution. |
|
I can even reproduce the issues using |
|
Hi, it looks like the Windows CI is still failing on this PR, and some unrelated code changes may not have been reverted yet. Could you please take another look? |
Closes #56
I had to fix the formatting and linting issues, so I could run the formatter and linter on my own changes without introducing unrelated changes in the same commit.