Skip to content

feat: Add option to set fwmark on the socket#60

Open
provokateurin wants to merge 2 commits into
aisk:masterfrom
provokateurin:feat/fwmark
Open

feat: Add option to set fwmark on the socket#60
provokateurin wants to merge 2 commits into
aisk:masterfrom
provokateurin:feat/fwmark

Conversation

@provokateurin

Copy link
Copy Markdown

Closes #56

I had to fix the formatting and linting issues, so I could run the formatter and linter on my own changes without introducing unrelated changes in the same commit.

@aisk

aisk commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Hi, please avoid the unrelated format changes. If we should fix the format issue, we can do it in a separated PR.

@provokateurin

Copy link
Copy Markdown
Author

That's why I put them into separate commits, so you can cleanly review the feature commit. I can create a separate PR to get them merged first, but I doesn't make much difference.

@aisk

aisk commented Jul 10, 2026

Copy link
Copy Markdown
Owner

I will squash merge this PR because I want to re-write the commit history to apply the gitmoji commit conversion, multiple changes in the same PR will block this.

And it makes the review a little bit more harder, also I know how to just check the diff in one commit, but other people may have trouble with it.

@provokateurin provokateurin marked this pull request as draft July 10, 2026 15:27
@provokateurin

Copy link
Copy Markdown
Author

I tried to use this change now, but it doesn't work. The ping stops working as soon as the fwmark is set. I first thought that it might only work on raw sockets (that's how I use it already), but switching to that didn't help. I'll mark this PR as ready, as soon as I've found a solution.

@provokateurin

Copy link
Copy Markdown
Author

I can even reproduce the issues using ping <address> -m <fwmark>. I'm using a different solution now. Feel free to still merge this PR.

@provokateurin provokateurin marked this pull request as ready for review July 10, 2026 15:49
@aisk

aisk commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Hi, it looks like the Windows CI is still failing on this PR, and some unrelated code changes may not have been reverted yet. Could you please take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting fwmark

2 participants